[alsa-devel] [PATCH] ALSA: firewire: remove support for 16 bit PCM samples in playback substream

[Takashi Iwai]

On Mon, 22 May 2017 16:21:47 +0200,
Clemens Ladisch wrote:
> 
> Takashi Sakamoto wrote:
> > As long as I know, models which support IEC 61883-1/6 doesn't allow to
> > switch bit length of PCM sample in MBLA data channel. They always
> > transmit/receive PCM frames of 24 bit length. This can be seen for the
> > other models which support protocols similar to IEC 61883-1/6.
> >
> > On the other hand, current drivers for these protocols supports 16 bit
> > length PCM sample in playback substream. In this case, PCM sample is put
> > into the MBLA data channel with 8 bit padding in LSB side. Although 16
> > bit PCM sample is major because it's in CD format, this doesn't represent
> > device capability as is.
> 
> I added 16-bit support in fear of programs that do not use automatic
> sample format conversion (hardcoded "hw:X" or OSS).
> 
> > This commit removes support for 16 bit PCM samples in playback substream.
> 
> Other devices without 16-bit support appear to work fine nowadays.
> 
> > Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
> 
> Acked-by: Clemens Ladisch <clemens at ladisch.de>

OK, applied now.  It's a nice reduction of codes!


thanks,

Takashi