[alsa-devel] linux-4.12-rc1/sound/soc/codecs/cs35l35.c: false comparison ?

[David Binderman]

hello there,

[linux-4.12-rc1/sound/soc/codecs/cs35l35.c:495] -> [linux-4.12-rc1/sound/soc/codecs/cs35l35.c:498]: (style) Mismatching assignment and comparison, comparison 'errata_chk==1' is always false.
[linux-4.12-rc1/sound/soc/codecs/cs35l35.c:495] -> [linux-4.12-rc1/sound/soc/codecs/cs35l35.c:498]: (style) Mismatching assignment and comparison, comparison 'errata_chk==3' is always false.

Source code is

    errata_chk = clk_ctl & CS35L35_SP_RATE_MASK;

    if (classh->classh_wk_fet_disable == 0x00 &&
        (errata_chk == 0x01 || errata_chk == 0x03)) {

but

./sound/soc/codecs/cs35l35.h:#define CS35L35_SP_RATE_MASK		0xC0

Regards

David Binderman