[alsa-devel] [PATCH 0/3] ALSA: USB-descriptor endianess fixes

Johan Hovold johan at kernel.org
Fri May 12 14:16:33 CEST 2017


On Fri, May 12, 2017 at 01:18:16PM +0200, Takashi Iwai wrote:
> On Fri, 12 May 2017 12:28:18 +0200,
> Johan Hovold wrote:
> > 
> > These patches add missing endianness conversions when accessing the USB
> > device-descriptor fields. In the process, clean up the us122l driver
> > which had product-id conditionals sprinkled throughout.
> > 
> > The final patch drops the Kconfig dependency on x86 since it's a USB
> > driver that compiles just fine on non-x86. Perhaps this should be a
> > (X86 || COMPILE_TEST) dependency instead in case there are external
> > dependencies that warrants this limitation.
> 
> Yeah, I vaguely remember that the driver is specific to x86 because of
> its particular usage of mmap.  Maybe some other architectures may
> match, but not all.  So, X86 || COMPILE_TEST would be more sensible.

Thanks for clarifying. I'll respin in a v2.

Johan


More information about the Alsa-devel mailing list