[alsa-devel] [PATCH] ASoC: rcar: ssi: don't set SSICR.CKDV = 000 with SSIWSR.CONT

[Sergei Shtylyov]

Hello!

On 3/22/2017 7:02 AM, Kuninori Morimoto wrote:

> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
>
> R-Car Datasheet is indicating "SSICR.CKDV = 000 is invalid when
> SSIWSR.WS_MODE = 1 or SSIWSR.CONT = 1".
> Current driver will set CONT, thus, we shouldn't use CKDV = 000.
> This patch fixup it.
>
> Reported-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx at renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> Tested-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx at renesas.com>
> ---
>  sound/soc/sh/rcar/ssi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
> index 9594d44..d0602c1 100644
> --- a/sound/soc/sh/rcar/ssi.c
> +++ b/sound/soc/sh/rcar/ssi.c
> @@ -245,6 +245,15 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod,
>  	for (j = 0; j < ARRAY_SIZE(ssi_clk_mul_table); j++) {
>
>  		/*
> +		 * It will set SSIWSR.CONT here, but SSICR.CKDV = 000
> +		 * with it is not allowed. (SSIWSR.WS_MODE with
> +		 * SSICR.CKDV = 000 is not allowed either).
> +		 * Skip it. See SSICR.CKDV
> +		 */
> +		if (j == 0)
> +			continue;

    Why not change the *for* statement itself to start with j = 1?

[...]

MBR, Sergei