[alsa-devel] [PATCH] ALSA: x86: Select CONFIG_HDMI_LPE_AUDIO as default

[Takashi Iwai]

On Wed, 15 Mar 2017 07:34:18 +0100,
Ian W MORRISON wrote:
> 
> The upstream kernel builds for distributions such as Ubuntu which now
> includes binary packages for v4.11 mainline kernel release candidates are
> promoted as a way of testing upstream kernels to to confirm that upstream
> has fixed a specific issue (see
> https://wiki.ubuntu.com/Kernel/MainlineBuilds).
> 
> Unfortunately the long awaited patch for providing HDMI audio support for
> Bay Trail and Cherry Trail devices does not include this support through a
> module built by default.
> 
> By defining the default of the two associated CONFIG settings (SND_X86 and
> HDMI_LPE_AUDIO) as a module, upstream kernel builds would automatically
> provide the much desired HDMI audio support by default.
> 
> This patch uses a Kconfig 'default' statement to include the driver as
> default.
> 
> Signed-off-by: Ian W Morrison <linuxium at linuxium.com.au>

Setting default=m is very uncommon and it already indicates something
wrong.

Instead, we should change CONFIG_SND_X86 to a bool like CONFIG_SND_PCI
or CONFIG_SND_ISA.  It's merely a config to filter its sub-options,
and this doesn't build any module by itself.

Then CONFIG_SND_X86 can be set safely to default y, as most of other
such configs do so for convenience, too.


thanks,

Takashi



> ---
>  sound/x86/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/x86/Kconfig b/sound/x86/Kconfig
> index 84c8f8fc..439850c 100644
> --- a/sound/x86/Kconfig
> +++ b/sound/x86/Kconfig
> @@ -1,6 +1,7 @@
>  menuconfig SND_X86
>         tristate "X86 sound devices"
>         depends on X86
> +       default m
>         ---help---
>           X86 sound devices that don't fall under SoC or PCI categories
> 
> @@ -9,6 +10,7 @@ if SND_X86
>  config HDMI_LPE_AUDIO
>         tristate "HDMI audio without HDaudio on Intel Atom platforms"
>         depends on DRM_I915
> +       default m
>         select SND_PCM
>         help
>          Choose this option to support HDMI LPE Audio mode
> -- 
> 1.9.1
> [2  <text/html; UTF-8 (quoted-printable)>]
>