[alsa-devel] [PATCH v3 6/7] ASoC: add audio-graph-card document

[Kuninori Morimoto]

Hi Rob

Thank you for your feedback

> > +- audio-graph-card,name
> > +- audio-graph-card,format
> > +- audio-graph-card,frame-master
> > +- audio-graph-card,bitclock-master
> > +- audio-graph-card,bitclock-inversion
> > +- audio-graph-card,frame-inversion
> > +- audio-graph-card,dai-tdm-slot-num
> > +- audio-graph-card,dai-tdm-slot-width
> 
> Sorry, I meant we should drop prefix ("audio-graph-card,") as these are 
> common properties and don't need a vendor prefix. We generally only do 
> prefixes when properties are vendor specifc and these are common. The 
> "simple-audio-card,*" prefix was a bit of an odd pattern.
> 
> Though if we do drop the prefix, just 'name' and 'format' are a bit 
> vague. Maybe dai-format instead of format. For name, I'm not sure how 
> that gets used. Does it really need to be per port? For user visible 
> names for things like identifying connectors on boards we use 'label', 
> so maybe that is appropriate here.

OK
In v4, I removed audio-graph-card prefix.
It has new label, and dai-format property

> > +- compatible				: "asoc-audio-graph-card";
> 
> Just audio-graph-card. asoc is a Linux term.

fixed in v4

> > +	dai-controller at 0 {
> 
> These should be audio-codec at ...

fixed in v4

Best regards
---
Kuninori Morimoto