[alsa-devel] [PATCH 1/5] ASoC: cs35l35: Add missing return in probe
Charles Keepax
ckeepax at opensource.wolfsonmicro.com
Wed Mar 8 17:42:47 CET 2017
A return statement is missing just before the error paths at the end of
probe. This causes us to fall straight into the error path and disable
the supplies and re-enable reset, as these are only controlled during
probe this causes the part to no longer function.
Signed-off-by: Charles Keepax <ckeepax at opensource.wolfsonmicro.com>
---
sound/soc/codecs/cs35l35.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
index 260ed42..48b45dc 100644
--- a/sound/soc/codecs/cs35l35.c
+++ b/sound/soc/codecs/cs35l35.c
@@ -1509,6 +1509,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
goto err;
}
+ return 0;
+
err:
regulator_bulk_disable(cs35l35->num_supplies,
cs35l35->supplies);
--
2.1.4
More information about the Alsa-devel
mailing list