[alsa-devel] [v5 1/2] ASoC: Add support for Cirrus Logic CS35L35 Amplifier

[Mark Brown]

On Fri, Mar 03, 2017 at 08:09:31AM -0600, Brian Austin wrote:

> +		regmap_update_bits(cs35l35->regmap, CS35L35_PWRCTL1,
> +					CS35L35_PDN_ALL_MASK, 0);
> +	break;
> +	case SND_SOC_DAPM_POST_PMD:

Coding style: break should be indented along with the code block (as it
is in the rest of the driver).

> +static const struct snd_kcontrol_new cs35l35_aud_controls[] = {
> +	SOC_SINGLE_SX_TLV("Digital Audio Volume", CS35L35_AMP_DIG_VOL,
> +		      0, 0x34, 0xE4, dig_vol_tlv),
> +	SOC_SINGLE_TLV("AMP Audio Gain", CS35L35_AMP_GAIN_AUD_CTL, 0, 19, 0,
> +			amp_gain_tlv),

Volume controls should always end in Volume so that userspace knows how
to handle them.

> +			case CS35L35_SP_SCLKS_32FS:
> +			case CS35L35_SP_SCLKS_64FS:
> +			break;
> +			default:

Indentation again.

> +err:
> +	regulator_bulk_disable(cs35l35->num_supplies,
> +			       cs35l35->supplies);
> +	/* should we release reset-gpio? */

Probably best to leave the device in reset, it'll make things a bit more
robust.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20170306/bf534114/attachment.sig>