[alsa-devel] [PATCH v2 2/3] ASoC: Intel: Convert all sst_codecs data defintion to c99 style

Vinod Koul vinod.koul at intel.com
Fri Jun 9 05:58:52 CEST 2017


On Wed, Jun 07, 2017 at 06:27:40PM -0700, Harsha Priya wrote:
> C99 style struct initialization helps in readability as well as
> initialization of variables not specified as NULL. This patch
> changes the struct data defintions in skl.c that were not in c99 style.

here as well :(

> ---
>  sound/soc/intel/skylake/skl.c | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
> index 4ebae85..6a79fc7 100644
> --- a/sound/soc/intel/skylake/skl.c
> +++ b/sound/soc/intel/skylake/skl.c
> @@ -876,10 +876,25 @@ static void skl_remove(struct pci_dev *pci)
>  	dev_set_drvdata(&pci->dev, NULL);
>  }
>  
> -static struct sst_codecs skl_codecs = { 1, {"NAU88L25"} };
> -static struct sst_codecs kbl_codecs = { 1, {"NAU88L25"} };
> -static struct sst_codecs bxt_codecs = { 1, {"MX98357A"} };
> -static struct sst_codecs kbl_poppy_codecs = { 1, {"10EC5663"} };
> +static struct sst_codecs skl_codecs = {
> +	.num_codecs = 1,
> +	.codecs = {"NAU88L25"}
> +};
> +
> +static struct sst_codecs kbl_codecs = {
> +	.num_codecs = 1,
> +	.codecs = {"NAU88L25"}
> +};
> +
> +static struct sst_codecs bxt_codecs = {
> +	.num_codecs = 1,
> +	.codecs = {"MX98357A"}
> +};
> +
> +static struct sst_codecs kbl_poppy_codecs = {
> +	.num_codecs = 1,
> +	.codecs = {"10EC5663"}
> +};
>  
>  static struct sst_acpi_mach sst_skl_devdata[] = {
>  	{
> -- 
> 1.9.1
> 

-- 
~Vinod


More information about the Alsa-devel mailing list