[alsa-devel] [PATCH] ASoC: dapm: Add new widget type for constructing DAPM graphs on DSPs.

[Pierre-Louis Bossart]

On 6/7/17 2:23 PM, Mark Brown wrote:
> On Tue, Jun 06, 2017 at 03:44:42PM +0100, Liam Girdwood wrote:
>
>> +	snd_soc_dapm_buffer,		/* DSP/CODEC internal buffer */
>> +	snd_soc_dapm_pipeline,		/* DSP/CODEC internal pipeline */
>> +	snd_soc_dapm_effect,		/* DSP/CODEC effect component */
>
> What's the difference between a buffer and a pipeline, or between a
> pipeline and an effect?  We should have clear documentation, if they're
> different we're probably going to end up using them differently in the
> core at some point and if people use the wrong widget type it might end
> up breaking things.

it would be good to explain how those elements are organized. Usually an 
effect/src/asrc is part of a pipeline, it's almost a subgraph within the 
flat dapm structure

>
>> +	snd_soc_dapm_codec,		/* FW/SW coder/decoder component */
>
> Can we call this a fmt_conv or something?  CODEC is unfortunately a bit
> overloaded.
>
>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>