[alsa-devel] [PATCH] ASoC: sgtl5000: Use snd_soc_kcontrol_codec()

[Richard Leitner]

On 07/20/2017 07:36 PM, Fabio Estevam wrote:
> Since commit a72952672005 ("ASoC: sgtl5000: add avc support") the
> following kernel crash happens after running a 'reboot' command:
> 
> ALSA: Storing mixer settings...
> [   20.031604] Unable to handle kernel paging request at virtual address fffffffe
> [   20.039268] pgd = de2a0000
> [   20.041999] [fffffffe] *pgd=8fffd861, *pte=00000000, *ppte=00000000
> [   20.048387] Internal error: Oops: 80000007 [#1] SMP ARM 
> 
> The function that takes a kcontrol parameter and returns the
> codec that registered the control is snd_soc_kcontrol_codec(),
> so use the correct function to fix the problem.
> 
> Fixes: a72952672005 ("ASoC: sgtl5000: add avc support")
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>

I've tested this patch on a custom i.MX6-DL board.
Although I wasn't able to reproduce the Ooops, setting and getting the
'AVC Threshold' wasn't working before that patch.
With this patch applied 'AVC Threshold' works fine! Thanks Fabio.

Therefore please feel free to add

Tested-by: Richard Leitner <richard.leitner at skidata.com>

And/Or

Reviewed-by: Richard Leitner <richard.leitner at skidata.com>

... whatever suits better.

kind regards,
Richard.L