[alsa-devel] [PATCH v4 2/2] ASoc: Add devictree bindings for CS35L35 CODEC

Brian Austin brian.austin at cirrus.com
Mon Jan 30 21:39:35 CET 2017


On Mon, 30 Jan 2017, Rob Herring wrote:

> On Wed, Jan 25, 2017 at 10:13:18AM -0600, Brian Austin wrote:
> > Add devicetree bindings documentatin for
> > Cirrus Logic CS35L35 Boosted Amplifier
> > 
> > Signed-off-by: Brian Austin <brian.austin at cirrus.com>
> > ---
> >  .../devicetree/bindings/sound/cs35l35.txt          | 171 +++++++++++++++++++++
> >  1 file changed, 171 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/sound/cs35l35.txt
> 
> This looks similar to the CS35L33. Please align the property names and 
> perhaps combine into a single binding doc.
> 
> Rob
> 
I can make sure the names are consistent for some of them but most of it 
would be messy to combine into a single doc IMO. I know it looks similar 
for some of them like the algorithm nodes but they are very different in 
parameters and operation.

Would it suffice to just make sure the properties that are the same be 
reflected across both docs?

Thanks
Brian


More information about the Alsa-devel mailing list