[alsa-devel] [PATCH 00/19][RFC v2] ALSA: firewire-motu: new driver for MOTU FireWire series

[Takashi Sakamoto]

On Jan 29 2017 22:34, Jonathan Woithe wrote:
> On Sun, Jan 29, 2017 at 12:53:58PM +0900, Takashi Sakamoto wrote:
>> This patchset updates a part of my previous RFC, just for MOTU FireWire
>> series.
>>
>> [RFC][PATCH 00/37] ALSA: firewire: support AMDTP variants
>> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-July/094789.html
>>
>> This patchset adds support for a part of MOTU FireWire series with their
>> functionality of packet streaming. Below models are newly supported:
>>  - 828
>>  - 828mk2
>>  - 828mk3 (FireWire/Hybrid)
>
> I like the general architecture of this driver.
>
> It's not clear to me whether you have utilised some information about these
> devices from FFADO or have duplicated the protocol reverse engineering
> process yourself.  If the former it would be nice to include a brief
> acknowlegement since the FFADO MOTU protocol documents and code represents a
> large body of work by several people which brought an otherwise undocumented
> protocol into the open.  If the latter then clearly it's a moot point.

If you had enough time to read codes in this patchset carefully and have 
enough knowledge about each layer related to packet streaming and IEEE 
1394 bus, you wouldn't have such opinion for this patchset.


Regards

Takashi Sakamoto