[alsa-devel] [bug report] ASoC: dapm: Implement and instantiate DAI widgets

[Mark Brown]

On Fri, Jan 20, 2017 at 10:52:31AM +0100, Linus Walleij wrote:
> On Thu, Jan 19, 2017 at 1:25 PM, Lars-Peter Clausen <lars at metafoo.de> wrote:

> > The warning is correct. It's just the wrong commit. The issue was introduced
> > with commit 37e1df8c95e2 ("ASoC: dapm: handle probe deferrals"). The commit
> > introduces ERR_PTR() as a possible return value for the function, but does
> > not update all callers.

> Yeah so the DAPM code was violating the regulator and clock
> APIs by ignoring potential error pointers (just doing NULL checks), so I
> made it aware of this, but oops it created a downstream problem that everyone
> using DAPM gets the cascaded error pointer.

> I just have to bit the bullet and make a patch updating all DAPM
> consumers, it's just work, I'll keep you in CC.

Yeah, the error handling was already broken - all your patch did was
make it easier for a static checker to spot that there were problems.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20170120/7f44a3da/attachment.sig>