[alsa-devel] [PATCH v4 6/9] ASoC: Intel: Skylake: Add supply widget in bxt_da_max machine

[Mark Brown]

On Mon, Jan 02, 2017 at 12:44:33PM +0530, jeeja.kp at intel.com wrote:

> +static int ssp_set_clk(struct snd_soc_dapm_widget *w,
> +		struct snd_kcontrol *k, int  event)
> +{
> +	struct snd_soc_dai *cpu_dai = NULL;
> +
> +	cpu_dai = skl_get_dai_widget(w);
> +	if (!cpu_dai)
> +		return -EIO;
> +
> +	/* Enable/Disable the SSP clk */
> +	if (SND_SOC_DAPM_EVENT_ON(event))
> +		return snd_soc_dai_set_tristate(cpu_dai, 0);
> +	else
> +		return snd_soc_dai_set_tristate(cpu_dai, 1);
> +}

Erk, no - you definitely want to just move the whole thing to DAPM I
think.  We shoudn't be manually fiddling with the tristating from driver
code when the core will also try to manage tristating, at some point
this widget and the core will inevitably end up fighting with each
other.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20170106/5a85ddb4/attachment.sig>