[alsa-devel] [PATCH v4 2/9] ASoC: Intel: Skylake: Add set_tristate DAI ops to enable SSP MCLK

[Mark Brown]

On Mon, Jan 02, 2017 at 12:44:29PM +0530, jeeja.kp at intel.com wrote:
> From: Jeeja KP <jeeja.kp at intel.com>
> 
> Some machine requires MCLK to be enabled before SSP start up, so add
> set_tristate() DAI ops to enable/disable SSP MCLK. This ops will be
> called from machine which requires early MCLK and removes the usage of
> enabling early MLCK in platform DAI prepare by default which is not
> machine specific.

This isn't an *obvious* use of the tristate operation...

> +	/*
> +	 * To enable ssp clk explicitly before gateway copier is configured,
> +	 * need to use dma control IPC.
> +	 * Disable will be done when DSP gateway copier modules are deleted.
> +	 */
> +	if (!tristate)
> +		return skl_dsp_set_dma_control(ctx, mconfig);

So we never clear this?  And to be frank I'd have no idea looking at
this that it's doing anything to do with clocks though that's a bit of a
separate thing.  It feels like DAPM might be a more natural place to do
this, have a clock widget supplying the AIF widget for the interface.
That'd be a bit more idiomatic.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20170106/7d565fe0/attachment.sig>