[alsa-devel] [PATCH] ASoC: pcm5102a: Provide a menu selection text

[Takashi Iwai]

On Thu, 05 Jan 2017 21:17:19 +0100,
Jörg Krause wrote:
> 
> On Thu, 2016-12-29 at 20:04 +0100, Takashi Iwai wrote:
> > On Thu, 29 Dec 2016 16:59:43 +0100,
> > Jörg Krause wrote:
> > > 
> > > On Wed, 2016-12-28 at 16:09 +0100, Takashi Iwai wrote:
> > > > On Tue, 20 Dec 2016 17:26:59 +0100,
> > > > Jörg Krause wrote:
> > > > > 
> > > > > Provide a menu selection text so that users can enable, disable
> > > > > or
> > > > > mark it as module in menuconfig.
> > > > 
> > > > What's the reason to enable it at all?  The codec entries are
> > > > usually
> > > > not user-selectable but enabled by the machine driver.
> > > 
> > > To allow using it with the simple-card driver.
> > 
> > See, now you know what's missing in your patch :)
> 
> Unforunately not. I adopted commit 465011fc5671 which does not has any
> dependency. Please enlighten me :)

The missing piece is one of the most important things in writing a
patch -- the proper information explaining "why" this change is
needed, preferably in a form of changelog text.  Instead, you wrote
merely what you changed, which is pretty obvious and doesn't help
understanding.

The commit you referred to is no good example in this manner at all,
unfortunately.


Takashi