[alsa-devel] [PATCH 3/3] ALSA: firewire-lib: change structure member with proper type

[Clemens Ladisch]

Takashi Sakamoto wrote:
> The 'amdtp_stream' structure is initialized by a call of
> 'amdtp_stream_init()'. Although a parameter of this function is for bit
> flags of packet attributes, its type is enumerator.

This is the correct type to use for an enumeration consisting of bit
flags.  What problem do you see with this?

>  int amdtp_stream_init(struct amdtp_stream *s, struct fw_unit *unit,
> -		      enum amdtp_stream_direction dir, enum cip_flags flags,
> +		      enum amdtp_stream_direction dir, int flags,
>  		      unsigned int fmt,


Regards,
Clemens