[alsa-devel] [PATCH v8 2/4] ASoC: Allow to select ES8328_I2C and ES8328_SPI directly
Romain Perier
romain.perier at collabora.com
Fri Feb 3 15:37:58 CET 2017
Currently, we have to select these symbols explictly via Kconfig, from
another entry. If we plan to use generic audio drivers like
simple-audio-card, the user need to be able to enable these symbols
directly via the menuconfig.
This commit also fixes unmet dependencies to SND_SOC_IMX_ES8328 caused
by these changes.
Signed-off-by: Romain Perier <romain.perier at collabora.com>
---
Changes in v8:
- Fixed unmet direct dependencies reported by kbuilt test robot:
"warning: (SND_SOC_IMX_ES8328 && SND_SOC_ALL_CODECS) selects
SND_SOC_ES8328_I2C which has unmet direct dependencies (SOUND && !M68K
&& !UML && SND && SND_SOC && SND_SOC_ES8328)
warning: (SND_SOC_IMX_ES8328 && SND_SOC_ALL_CODECS) selects
SND_SOC_ES8328_SPI which has unmet direct dependencies (SOUND && !M68K
&& !UML && SND && SND_SOC && SND_SOC_ES8328)
"
Changes in v7:
- Added this commit
sound/soc/codecs/Kconfig | 8 ++++----
sound/soc/fsl/Kconfig | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 9e1718a..cfa4233 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -528,12 +528,12 @@ config SND_SOC_ES8328
tristate "Everest Semi ES8328 CODEC"
config SND_SOC_ES8328_I2C
- tristate
- select SND_SOC_ES8328
+ depends on SND_SOC_ES8328
+ tristate "I2C support for Everest Semi ES8328 CODEC"
config SND_SOC_ES8328_SPI
- tristate
- select SND_SOC_ES8328
+ depends on SND_SOC_ES8328
+ tristate "SPI support for Everest Semi ES8328 CODEC"
config SND_SOC_GTM601
tristate 'GTM601 UMTS modem audio codec'
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 37f9b62..0b914a1 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -244,7 +244,7 @@ config SND_SOC_IMX_WM8962
config SND_SOC_IMX_ES8328
tristate "SoC Audio support for i.MX boards with the ES8328 codec"
- depends on OF && (I2C || SPI)
+ depends on OF && (I2C || SPI) && SND_SOC_ES8328
select SND_SOC_ES8328_I2C if I2C
select SND_SOC_ES8328_SPI if SPI_MASTER
select SND_SOC_IMX_PCM_DMA
--
2.9.3
More information about the Alsa-devel
mailing list