[alsa-devel] [alsa-lib][PATCH 0/4] pcm: minor code cleanup

Takashi Sakamoto o-takashi at sakamocchi.jp
Fri Dec 22 00:25:42 CET 2017


Hi,

On Dec 21 2017 23:46, Takashi Iwai wrote:
> On Wed, 20 Dec 2017 18:16:59 +0100,
> Takashi Sakamoto wrote:
>>
>> Hi,
>>
>> When reviewing Maciej's patches[1], I found that alsa-lib includes some
>> unused codes in linear interpolation functionality. Furthermore, some code
>> comments includes 'copy & paste' mistakes.
>>
>> This patchset improves them.
>>
>> [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2017-December/129370.html
>>
>> Takashi Sakamoto (4):
>>    pcm: remove unused macros of COPY_LABELS/COPY_END
>>    pcm: remove unused macros of GETU_LABELS/GETU_END
>>    pcm: remove unused macros of NORMS_LABELS/NORMS_END
>>    pcm: fix wrong comments for some cases of linear interpolation of PCM
>>      samples
> 
> All patches seem missing your sign-off.
> It's not mandatory for alsa-lib, but preferable.  Would you like me
> adding them manually?

Oops... Yes, please.
(I should have a script to check it before posting...)


Thanks

Takashi Sakamoto


More information about the Alsa-devel mailing list