[alsa-devel] [RFC v3 06/11] ASoC: hdac_hda: add ASoC based HDA codec driver

[Ughreja, Rakesh A]

>-----Original Message-----
>From: Mark Brown [mailto:broonie at kernel.org]
>Sent: Wednesday, December 20, 2017 3:56 PM
>To: Takashi Iwai <tiwai at suse.de>
>Cc: Ughreja, Rakesh A <rakesh.a.ughreja at intel.com>; alsa-devel at alsa-
>project.org; Koul, Vinod <vinod.koul at intel.com>; pierre-
>louis.bossart at linux.intel.com; liam.r.girdwood at linux.intel.com; Patches Audio
><patches.audio at intel.com>
>Subject: Re: [alsa-devel] [RFC v3 06/11] ASoC: hdac_hda: add ASoC based
>HDA codec driver
>
>On Tue, Dec 19, 2017 at 08:17:37PM +0100, Takashi Iwai wrote:
>
>> Well, honestly speaking, that complete morphing scares me.  If it's a
>> simple additional call, it's easier to track the code flow.  But your
>> patch essentially fakes the legacy codec and bus structs and twists
>> the control by that switch...  which looks too fragile to me.
>
>Especially when it's layered on top of all the other x86 code which is
>also complicated and fragile - feels like there's lots of places things
>can go wrong and lots of potential unexpected interactions.

Thanks, for the feedback Mark and Takashi. I will send the test patch 
based on the suggestions from Takashi within couple of days.

Regards,
Rakesh