[alsa-devel] [PATCH v9 10/13] IIO: ADC: add stm32 DFSDM support for PDM microphone

[gianluca]

On 12/17/2017 01:54 PM, Jonathan Cameron wrote:
> On Thu, 14 Dec 2017 09:58:02 +0100
>> +static ssize_t dfsdm_adc_audio_set_spiclk(struct iio_dev *indio_dev,
>> +					  uintptr_t priv,
>> +					  const struct iio_chan_spec *chan,
>> +					  const char *buf, size_t len)
>> +{
>> +	struct stm32_dfsdm_adc *adc = iio_priv(indio_dev);
>> +	struct stm32_dfsdm_filter *fl = &adc->dfsdm->fl_list[adc->fl_id];
>> +	struct stm32_dfsdm_channel *ch = &adc->dfsdm->ch_list[adc->ch_id];
>> +	unsigned int sample_freq = adc->sample_freq;
>> +	unsigned int spi_freq;
>> +	int ret;
>> +
>> +	dev_err(&indio_dev->dev, "enter %s\n", __func__);
         ^^^^^^^

Why dev_err() and not dev_dbg()??? I suppose to force the log even with 
a lower debuglevel value, but it is wrong here. It could be better a 
dev_warn() if you want to notify the calling of this function anyway,



-- 
Eurek s.r.l.                          |
Electronic Engineering                | http://www.eurek.it
via Celletta 8/B, 40026 Imola, Italy  | Phone: +39-(0)542-609120
p.iva 00690621206 - c.f. 04020030377  | Fax:   +39-(0)542-609212