[alsa-devel] About ASoC DAIs cleanup

Vinod Koul vinod.koul at intel.com
Fri Dec 15 05:20:53 CET 2017


On Thu, Dec 14, 2017 at 11:37:18AM +0000, Mark Brown wrote:
> On Thu, Dec 14, 2017 at 10:36:48AM +0530, Vinod Koul wrote:
> > On Thu, Dec 14, 2017 at 03:07:30AM +0000, Kuninori Morimoto wrote:
> 
> > > > Cleaning things up so we don't need to use rtd->cpu_dai and rtd->codec_dai
> > > > would definitely be nice, it's also useful for CODEC<->CODEC links.  Off
> > > > the top of my head wrapping the accesses with macros/functions then
> > > > implementing a way of getting the DAI behind them would be tractable?
> 
> > Yes but one of the problems I see that we have specific ordering on the
> > DAI ops between various components, is that a specific requirement?
> 
> It's designed to minimize pops, it's not a hard requirement but changing
> it might break things for existing systems.

Yes that was my hunch too, so lets keep the order unchanged.

> > > 	3rd step: think about No-Categorized DAI (if possible)
> > > Because many drivers are directly using rtd->cpu_dai, rtd->codec_dai
> 
> > We should fix that part while at it. I guess drivers needs own dai,
> > possibly for name or some data, so if they have helpers for that, we
> > should be able to remove those..
> 
> The drivers need some way to get their driver data back and to know
> which DAI to address on multi device hardware.  Most of the callbacks
> get the DAI passed in directly, that's the simplest thing.

Precisely :)

-- 
~Vinod


More information about the Alsa-devel mailing list