[alsa-devel] Question about soc-utils

Mark Brown broonie at kernel.org
Wed Dec 6 13:47:42 CET 2017


On Wed, Dec 06, 2017 at 05:26:54AM +0000, Kuninori Morimoto wrote:

> > > That's just an oversight, it should be using the sample size.

> The original commit was below.
> It seems original code was also assuming format width.
> Was this also oversight ?
> format_width -> physical_width changes meaning, I think...

> -	switch (params_format(params)) {
> -	case SNDRV_PCM_FORMAT_S16_LE:
> -	case SNDRV_PCM_FORMAT_S16_BE:
> -		sample_size = 16;
> -		break;
> -	case SNDRV_PCM_FORMAT_S20_3LE:
> -	case SNDRV_PCM_FORMAT_S20_3BE:
> -		sample_size = 20;
> -		break;

Ah, sorry - I misread what you were saying.  The above is the intention.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20171206/9bb901a4/attachment.sig>


More information about the Alsa-devel mailing list