[alsa-devel] [RFC 03/10] ASoC: Intel: Skylake: add HDA BE DAIs

[Pierre-Louis Bossart]

On 12/1/17 3:14 AM, Rakesh Ughreja wrote:
> Add support for HDA BE DAIs in SKL platform driver.
> 
> Signed-off-by: Rakesh Ughreja <rakesh.a.ughreja at intel.com>
> ---
>   sound/soc/intel/skylake/skl-pcm.c | 32 +++++++++++++++++++++++++-------
>   1 file changed, 25 insertions(+), 7 deletions(-)
> 
> diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
> index e6fee7a..3dcb241 100644
> --- a/sound/soc/intel/skylake/skl-pcm.c
> +++ b/sound/soc/intel/skylake/skl-pcm.c
> @@ -956,21 +956,39 @@ static struct snd_soc_dai_driver skl_platform_dai[] = {
>   	},
>   },
>   {
> -	.name = "HD-Codec Pin",
> +	.name = "Analog CPU DAI",
>   	.ops = &skl_link_dai_ops,
>   	.playback = {
> -		.stream_name = "HD-Codec Tx",
> -		.channels_min = HDA_STEREO,
> +		.stream_name = "Analog CPU Playback",
> +		.channels_min = HDA_MONO,
>   		.channels_max = HDA_STEREO,
>   		.rates = SNDRV_PCM_RATE_48000,
> -		.formats = SNDRV_PCM_FMTBIT_S16_LE,
> +		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,
>   	},
>   	.capture = {
> -		.stream_name = "HD-Codec Rx",
> -		.channels_min = HDA_STEREO,
> +		.stream_name = "Analog CPU Capture",
> +		.channels_min = HDA_MONO,
>   		.channels_max = HDA_STEREO,
>   		.rates = SNDRV_PCM_RATE_48000,
> -		.formats = SNDRV_PCM_FMTBIT_S16_LE,
> +		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,
> +	},
> +},
> +{
> +	.name = "Digital CPU DAI",

I am not sure I get the meaning of analog/digital.

Did you mean external codec vs. iDisp codec?

Or did you really mean analog? I don't think you can control this front 
the CPU side, e.g. if the codec has an S/PDIF output it remains digital.

> +	.ops = &skl_link_dai_ops,
> +	.playback = {
> +		.stream_name = "Digital CPU Playback",
> +		.channels_min = HDA_MONO,
> +		.channels_max = HDA_STEREO,
> +		.rates = SNDRV_PCM_RATE_48000,
> +		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,
> +	},
> +	.capture = {
> +		.stream_name = "Digital CPU Capture",
> +		.channels_min = HDA_MONO,
> +		.channels_max = HDA_STEREO,
> +		.rates = SNDRV_PCM_RATE_48000,
> +		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,
>   	},
>   },
>   };
>