[alsa-devel] [PATCH 00/14] BYT/CHT codec/machine drivers update
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Tue Aug 29 20:51:33 CEST 2017
On 8/29/17 1:34 PM, Mark Brown wrote:
> On Mon, Aug 28, 2017 at 06:38:25AM -0500, Pierre-Louis Bossart wrote:
>> Mark, please don't merge this for now. There were a couple of minor comments
>> sent privately to me and I need to address them. I will send an update later
>> this week. Thanks.
>
> OK, I did also send you a very major comment about the missing signoffs
> on a lot of the patches...
I must have had an email issue, I didn't see your replies and which
patches you merged, sorry about the noise.
Yes, the missing signed-offs were flagged by Vinod, i didn't know they
were required since they were already posted a while back and I didn't
touch those patches. Point taken, i already fixed this. There was
another issue with a missing error handling which is agreed on with
Thierry Escande. I am also planning to get more testing done for the
maxim codec, I am told that the machine driver worked as is but the code
can't possibly function with a mismatch of both protocol and slot width
so there is something fishy to look into.
More information about the Alsa-devel
mailing list