[alsa-devel] [PATCH] ASoC: tas2552: Propagate the error code in suspend/resume

[Dan Murphy]

On 04/24/2017 07:43 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at nxp.com>
> 
> tas2552_suspend() and tas2552_resume() currently always return success,
> even though they may fail.
> 
> Fix this behaviour by always propagating the error code.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>

Reviewed-by: Dan Murphy <dmurphy at ti.com>

> ---
>  sound/soc/codecs/tas2552.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
> index fd5251e..8840f72 100644
> --- a/sound/soc/codecs/tas2552.c
> +++ b/sound/soc/codecs/tas2552.c
> @@ -637,7 +637,7 @@ static int tas2552_suspend(struct snd_soc_codec *codec)
>  	if (ret != 0)
>  		dev_err(codec->dev, "Failed to disable supplies: %d\n",
>  			ret);
> -	return 0;
> +	return ret;
>  }
>  
>  static int tas2552_resume(struct snd_soc_codec *codec)
> @@ -653,7 +653,7 @@ static int tas2552_resume(struct snd_soc_codec *codec)
>  			ret);
>  	}
>  
> -	return 0;
> +	return ret;
>  }
>  #else
>  #define tas2552_suspend NULL
> 


-- 
------------------
Dan Murphy