[alsa-devel] [PATCH] ASoC: cs35l35: Allow user to configure IMON SCALE

Rob Herring robh at kernel.org
Thu Apr 20 00:32:58 CEST 2017


On Thu, Apr 13, 2017 at 04:52:09PM +0100, Charles Keepax wrote:
> On the chip the IMON signal is a full 24-bits however normally only
> some of the bits will be sent over the bus. The chip provides a field
> to select which bits of the IMON will be sent back, this is the only
> feedback signal that has this feature.
> 
> Add an additional entry to the cirrus,imon device tree property to
> allow the IMON scale parameter to be passed.
> 
> Signed-off-by: Charles Keepax <ckeepax at opensource.wolfsonmicro.com>
> ---
> 
> I realise this is changing the binding slightly, but thought
> we might be able to sneak it before cs35l35 ships as it hasn't
> shipped in a kernel yet.  However, it would be relatively simple
> (although makes the code a little messier) to support both the 3
> and 4 entry versions of the binding if people prefer?

Given it is new, I'm okay with the change if you are.

> 
> Thanks,
> Charles
> 
>  .../devicetree/bindings/sound/cs35l35.txt          |  4 ++--

Acked-by: Rob Herring <robh at kernel.org>

>  include/sound/cs35l35.h                            |  1 +
>  sound/soc/codecs/cs35l35.c                         | 22 +++++++++++++++-------
>  sound/soc/codecs/cs35l35.h                         |  3 +++
>  4 files changed, 21 insertions(+), 9 deletions(-)


More information about the Alsa-devel mailing list