[alsa-devel] [PATCH 1/2] ASoC: cs4341: Add driver for CS4341 CODEC

[Handrigan, Paul]

On 9/21/16, 3:59 AM, "Alexander Shiyan" <shc_work at mail.ru> wrote:

>>On 9/8/16, 11:29 AM, "Alexander Shiyan" < shc_work at mail.ru > wrote:
>>
>...
>>>+config SND_SOC_CS4341
>>>+tristate "Cirrus Logic CS4341 CODEC"
>>>+depends on SPI_MASTER
>>>+select REGMAP_SPI
>>>+help
>>>+  Enable support for Cirrus Logic (Crystal) CS4341 CODEC.
>>>+
>>This devices primary interface is I2C.  That should be added as well
>>since
>>i2c is read/write and spi is write only.
>
>I can add I2C support, but can not test this.

OK, that is fine.  We can add a patch to support I2C after that.
>
>...
>>>+snd_soc_update_bits(codec, CS4341_REG_MODE2, CS4341_MODE2_DIF,
>>>+    bits24 ? CS4341_MODE2_DIF_RJ_24 :
>>>+    CS4341_MODE2_DIF_RJ_16);
>>>+break;
>>>+default:
>>>+dev_err(codec->dev, "Unsupported DAI format\n");
>>>+return -EINVAL;
>>>+}
>>
>>Can we use regmap_update_bits where we can?
>
>So you say that regmap_update_bits() is prefferred than
>snd_soc_update_bits() ?

Yes.
>
>---
>
>_______________________________________________
>Alsa-devel mailing list
>Alsa-devel at alsa-project.org
>https://urldefense.proofpoint.com/v2/url?u=http-3A__mailman.alsa-2Dproject
>.org_mailman_listinfo_alsa-2Ddevel&d=DQICAg&c=O3LcjD-V2Iepl5V0N1424A&r=NJt
>NI3T_InLOY17xIGk4jdUC7XljFdoy6miaxhGHOOI&m=D9AVC8o2an1rQHYC1xfoGKGHyAfKmCk
>0R0ahr8l8n3Q&s=EaM-NwVFymokJtsVOM7graacnT_2n68TY32zeMkDSbw&e=