[alsa-devel] [PATCH] ALSA: usb-line6: use the same declaration as definition in header for MIDI manufacturer ID

[Takashi Iwai]

On Sun, 25 Sep 2016 15:00:20 +0200,
Takashi Sakamoto wrote:
> 
> Currently, usb-line6 module exports an array of MIDI manufacturer ID and
> usb-pod module uses it. However, the declaration is not the definition in
> common header. The difference is explicit length of array. Although
> compiler calculates it and everything goes well, it's better to use the
> same representation between definition and declaration.
> 
> This commit fills the length of array for usb-line6 module. As a small
> good sub-effect, this commit suppress below warnings from static analysis
> by sparse v0.5.0.
> 
> sound/usb/line6/driver.c:274:43: error: cannot size expression
> sound/usb/line6/driver.c:275:16: error: cannot size expression
> sound/usb/line6/driver.c:276:16: error: cannot size expression
> sound/usb/line6/driver.c:277:16: error: cannot size expression
> 
> Fixes: 705ececd1c60 ("Staging: add line6 usb driver")
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

Applied, thanks.


Takashi


> ---
>  sound/usb/line6/driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
> index f9224ec..ad7efc0 100644
> --- a/sound/usb/line6/driver.c
> +++ b/sound/usb/line6/driver.c
> @@ -30,7 +30,7 @@
>  /*
>  	This is Line 6's MIDI manufacturer ID.
>  */
> -const unsigned char line6_midi_id[] = {
> +const unsigned char line6_midi_id[3] = {
>  	0x00, 0x01, 0x0c
>  };
>  EXPORT_SYMBOL_GPL(line6_midi_id);
> -- 
> 2.7.4
>