[alsa-devel] [PATCH 1/4] ASoC: rt286: rt286_mic_detect() uses component

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Wed Oct 26 06:48:29 CEST 2016


Hi Mark, Lars, Vinod

> > Maybe somebody from the Intel side can look into fixing this. The affected
> > boards are cht_bsw_rt5672 and broadwell, which both access the cards
> > codec_dev_list field.
> 
> This also exists in some customer SKL machines.
> 
> I agree that this may not be best implementation so I can send a patch for
> this.
> 
> As Lars suggested we can use DAI link init callback, but then I dont feel it
> is right to use rtd->codec to get codec pointer, again we will be looking
> into rtd internals. So would make sense to combine two suggestion and add an
> API:
> 
> struct snd_soc_codec *snd_soc_get_codec(struct snd_soc_pcm_runtime *rtd)
> {
> 	return rtd->codec;
> }
> 
> then we can use this is drivers.
> 
> Let me know if all are in agreement, I can test this and send out..

I guess my patch series should based on Vinod's new patch
which doesn't use codec_dev_list ?
Or can I post separately ?

Vinod, can you please Cc to me about your new patch ?


More information about the Alsa-devel mailing list