[alsa-devel] [PATCH 2/2] ASoC: add Component level suspend/resume

[Kuninori Morimoto]

Hi Lars

> > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > 
> > In current ALSA SoC, Codec only has suspend/resume feature.
> > But it should be supported on Component level. This patch adds it.
> > This patch replaces current codec_dev_list to component_dev_list.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> 
> This looks good, but can you move the removal of the codec_dev_list to a
> separate patch. This will make it more clear what is going on. One patch to
> move suspend to component, one patch to cleanup and remove codec_dev_list.

OK, will do in v3

> >  static int broadwell_suspend(struct snd_soc_card *card){
> > -	struct snd_soc_codec *codec;
> > +	struct snd_soc_component *component;
> >  
> > -	list_for_each_entry(codec, &card->codec_dev_list, card_list) {
> > +	list_for_each_entry(component, &card->component_dev_list, card_list) {
> > +		struct snd_soc_codec *codec = snd_soc_component_to_codec(component);
> 
> The case should happen after the name has been matched, otherwise we are
> casting components that are not CODECs. Same for the other similar places.

OK