[alsa-devel] [PATCH 1/2] ASoC: core: add component_dev_list on Card
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Tue Oct 25 11:43:36 CEST 2016
Hi Lars
> > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> >
> > Current Card has Codec list (= codec_dev_list), but Codec will be
> > removed in the future. Because of this reason, this patch adds
> > new Component list in Card.
> > In the same time, current Card has AUX list (= aux_comp_list).
> > This patch replaces it by Component list and new flag (= has_auxliary)
> > too
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
>
> Looks mostly good, thanks.
Thanks
> > @@ -807,9 +807,10 @@ struct snd_soc_component {
> >
> > unsigned int ignore_pmdown_time:1; /* pmdown_time is ignored at stop */
> > unsigned int registered_as_component:1;
> > + unsigned int has_auxiliary:1; /* for auxiliary component of the card */
>
> I'd name it just auxiliary. "has" is not really the right word here.
OK, will fix in v3, and post it tomorrow
More information about the Alsa-devel
mailing list