[alsa-devel] [SAMPLE-PATCH 0/x] ASoC: replace snd_soc_read/write
Takashi Iwai
tiwai at suse.de
Wed Oct 19 09:30:33 CEST 2016
On Wed, 19 Oct 2016 07:50:08 +0200,
Kuninori Morimoto wrote:
>
>
> Hi Mark, Lars-Peter
>
> These are part of "replace snd_soc_read/write to snd_soc_component_read/write"
> patch-set. Full-patch-set will be over 100 patches.
>
> [0/x] - [x-1/x] : ASoC: use snd_soc_component_read/write on xxxx
> [x/x] : ASoC: remove snd_soc_component_read/write
>
> [0/x] - [x-1/x] are almost same patches.
> so, I pickuped few of them for reviewing to avoid patch flood on ML.
>
> If these review were OK, I will post full-patch-set,
> or send git-pull-request.
>
> Main purpose of these patches are replace current snd_soc_read/write
> to snd_soc_component_read/write to remove codec related function.
I really don't see any big merits by these changes.
What's wrong with keeping as is? The driver is accessing the codec
register, after all.
For keeping consistency, replacing a few exceptions would be OK. But
replacing hundreds of callers needs a proper justification to do it
so.
thanks,
Takashi
More information about the Alsa-devel
mailing list