[alsa-devel] [PATCH] ALSA: seq: fix passing wrong pointer in function call of compatibility layer

[Takashi Iwai]

On Wed, 12 Oct 2016 02:05:50 +0200,
Takashi Sakamoto wrote:
> 
> This commit is a fix for Linux 4.9-rc1.
> 
> In former commit, a function call of compatibility layer for ALSA sequencer
> core was obsoleted by an alternative. Although, the alternative gets a
> pointer to kernel stack due to mis-programming. As a result, ALSA sequencer
> core unexpectedly refers over kernel stack.
> 
> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> Fixes: 8ce8eb601c71 ("ALSA: seq: add an alternative way to handle ioctl requests")
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

Applied, thanks.


Takashi

> ---
>  sound/core/seq/seq_compat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/seq/seq_compat.c b/sound/core/seq/seq_compat.c
> index fce5697..8c35072 100644
> --- a/sound/core/seq/seq_compat.c
> +++ b/sound/core/seq/seq_compat.c
> @@ -58,7 +58,7 @@ static int snd_seq_call_port_info_ioctl(struct snd_seq_client *client, unsigned
>  		goto error;
>  	data->kernel = NULL;
>  
> -	err = snd_seq_kernel_client_ctl(client->number, cmd, &data);
> +	err = snd_seq_kernel_client_ctl(client->number, cmd, data);
>  	if (err < 0)
>  		goto error;
>  
> -- 
> 2.7.4
>