[alsa-devel] [PATCH] ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040

[Takashi Iwai]

On Wed, 30 Nov 2016 17:36:15 +0100,
Vinod Koul wrote:
> 
> On Wed, Nov 30, 2016 at 05:19:20PM +0100, Takashi Iwai wrote:
> > Dell Wyse 3040 requires the platform workaround for enabling dmic and
> > jack detection as defined for Braswell CRB.
> > 
> > Signed-off-by: Takashi Iwai <tiwai at suse.de>
> > 
> > ---
> > 
> > I guess the platform data should be applied generically to all CHT
> > machines instead of DMI matching?  DMI matching doesn't scale,
> > obviously.
> 
> we ahve been doing this on other RT codecs like RT286/298 as well for combo
> jack to work. Yeah a better solution would be welcomed :)

Well, the question is how generic the given platform-specific setup
is.  I guess we can keep the dmi thingy for a while, although we'll
need more generic solution (or a pattern matching for a wider range of
machines).  So, if you think the addition of DMI entries is OK, give
your ack :)


thanks,

Takashi


> 
> > 
> >  sound/soc/codecs/rt5670.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c
> > index 98c7efbc6ee0..97bafac3bc15 100644
> > --- a/sound/soc/codecs/rt5670.c
> > +++ b/sound/soc/codecs/rt5670.c
> > @@ -2827,6 +2827,13 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = {
> >  			DMI_MATCH(DMI_BOARD_NAME, "Braswell CRB"),
> >  		},
> >  	},
> > +	{
> > +		.ident = "Dell Wyse 3040",
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"),
> > +		},
> > +	},
> >  	{}
> >  };
> >  
> > -- 
> > 2.10.2
> > 
> 
> -- 
> ~Vinod
>