[alsa-devel] [PATCH v2] dbri: Fix compiler warning

David Miller davem at davemloft.net
Thu Nov 24 17:20:57 CET 2016


From: Takashi Iwai <tiwai at suse.de>
Date: Thu, 24 Nov 2016 13:59:10 +0100

> On Thu, 24 Nov 2016 04:15:15 +0100,
> Tushar Dave wrote:
>> 
>> @@ -2539,7 +2545,7 @@ static int snd_dbri_create(struct snd_card *card,
>>  	if (!dbri->dma)
>>  		return -ENOMEM;
>>  
>> -	dprintk(D_GEN, "DMA Cmd Block 0x%p (0x%08x)\n",
>> +	dprintk(D_GEN, "DMA Cmd Block 0x%p (0x%08llx)\n",
>>  		dbri->dma, dbri->dma_dvma);
> 
> Better to use %pad for dma_addr_t here.
> If the config doesn't enable ATU, dma_addr_t would be still u32, and
> your change will be buggy.

dma_addr_t is unconditionally a 64-bit type on sparc64.

However, you are right in that on sparc32 it is still 32-bit.




More information about the Alsa-devel mailing list