[alsa-devel] [PATCH] pcm_dshare: Do not discard slave reported delay in status result.

Alan Young Alan.Young at IEE.org
Thu Nov 17 15:18:04 CET 2016


On 17/11/16 10:31, Takashi Iwai wrote:
> On Thu, 17 Nov 2016 09:20:16 +0100,
> Alan Young wrote:
>> snd_pcm_dshare_status() gets the underlying status from the slave PCM.
>> This may contain a delay value that includes elements such as codec and
>> other transfer delays. Use this as the base for the returned delay
>> value, adjusted for any frames buffered locally (within the dshare
>> plugin).
>>
>> Note: snd_pcm_dshare_delay() is not updated.
> Thanks for the patch, but it doesn't look like a proper patch to be
> applied to the latest git tree.  I guess you created a patch on top of
> the modified tree.
>
> Please rebase and resubmit.
>
> Also, don't forget to add your sign-off.  We prefer having it in
> alsa-lib code like the kernel code (although it's not strictly
> needed).

I can add a signoff but first I need to understand what is wrong with 
the patch.

I did a git pull of master from git://git.alsa-project.org/alsa-lib.git, 
committed my patch on top (previous commit a668a94238d: "mixer: Don't 
install smixer modules unless python is enabled") and did a git 
format-patch to generate the supplied patch. What did I do wrong?



More information about the Alsa-devel mailing list