[alsa-devel] [PATCH 01/19] ASoC: uda1380: Convert to module_i2c_driver()

[Lars-Peter Clausen]

On 11/15/2016 07:42 AM, Kuninori Morimoto wrote:
> 
> HI Takashi-san
> 
>>>  config SND_SOC_UDA1380
>>>          tristate
>>> +	depends on I2C
>>
>> Note that this doesn't help when it's reverse-selected by others.
>>
>> The same is true for an item with a prompt, but the item like this
>> without prompt is supposed to be reverse-selected only, so adding
>> "depends on" there is merely a placeholder.
>>
>> That being said, currently the only way to guarantee the dependency by
>> a reverse-selection is to put the depends-on to the selecting item,
>> not to the selected item.
>>
>> It's a generic problem of the kbuild implementation, and people know
>> of it over a decade.  It was discussed in the previous Plumbers
>> conference, and developers agreed to improve the situation, so it may
>> be a bit better in near future.
> 
> Hmm.. indeed thanks for your feedback.
> So, should I send v2 patch ? or as-is is OK at this point ?

While it doesn't prevent the symbol from being selected this will generate a
warning if the symbol is selected while its dependencies are not met. So I'd
say it is still useful to have.