[alsa-devel] [PATCH 01/19] ASoC: uda1380: Convert to module_i2c_driver()

[Takashi Iwai]

On Tue, 15 Nov 2016 06:09:19 +0100,
Kuninori Morimoto wrote:
> 
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> uda1380 driver doesn't work without CONFIG_I2C anyway.
> Let's depend on it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> ---
>  sound/soc/codecs/Kconfig   |  1 +
>  sound/soc/codecs/uda1380.c | 22 +---------------------
>  2 files changed, 2 insertions(+), 21 deletions(-)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index f1c48d2..2e7eb36 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -874,6 +874,7 @@ config SND_SOC_UDA134X
>  
>  config SND_SOC_UDA1380
>          tristate
> +	depends on I2C

Note that this doesn't help when it's reverse-selected by others.

The same is true for an item with a prompt, but the item like this
without prompt is supposed to be reverse-selected only, so adding
"depends on" there is merely a placeholder.

That being said, currently the only way to guarantee the dependency by
a reverse-selection is to put the depends-on to the selecting item,
not to the selected item.

It's a generic problem of the kbuild implementation, and people know
of it over a decade.  It was discussed in the previous Plumbers
conference, and developers agreed to improve the situation, so it may
be a bit better in near future.


thanks,

Takashi