[alsa-devel] [PATCH 2/3] ASoC: Intel: atom: save FW version

[Sebastien Guiriec]

Hi Vinod,


On 07/11/2016 22:01, Vinod Koul wrote:
> On Fri, Nov 04, 2016 at 09:04:10AM +0100, Sebastien Guiriec wrote:
>> After the boot of the SST FW the firmware version is send back
>> to the driver. This patch is saving the FW version inside the
>> driver.
>>
>> Signed-off-by: Sebastien Guiriec <sebastien.guiriec at intel.com>
>> ---
>>  sound/soc/intel/atom/sst/sst.h     | 1 +
>>  sound/soc/intel/atom/sst/sst_ipc.c | 5 +++++
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/sound/soc/intel/atom/sst/sst.h b/sound/soc/intel/atom/sst/sst.h
>> index 3f49386..5c9a51cc 100644
>> --- a/sound/soc/intel/atom/sst/sst.h
>> +++ b/sound/soc/intel/atom/sst/sst.h
>> @@ -436,6 +436,7 @@ struct intel_sst_drv {
>>  	 */
>>  	char firmware_name[FW_NAME_SIZE];
>>
>> +	struct snd_sst_fw_version fw_version;
>
> Can you check if this is initialzed to zero, otherwise we should reset it..
>

Driver is using devm_kzalloc so it is set to 0.

Seb
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.