[alsa-devel] [PATCH v6 02/11] ASoC: topology: Make PCM backward compatible from ABI v4

[Lin, Mengdong]

> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: Saturday, October 29, 2016 2:51 AM
> To: mengdong.lin at linux.intel.com
> Cc: alsa-devel at alsa-project.org; tiwai at suse.de;
> liam.r.girdwood at linux.intel.com; Shah, Hardik T <hardik.t.shah at intel.com>;
> Singh, Guneshwor O <guneshwor.o.singh at intel.com>; Koul, Vinod
> <vinod.koul at intel.com>; Ughreja, Rakesh A <rakesh.a.ughreja at intel.com>;
> Lin, Mengdong <mengdong.lin at intel.com>
> Subject: Re: [PATCH v6 02/11] ASoC: topology: Make PCM backward
> compatible from ABI v4
> 
> On Tue, Oct 11, 2016 at 02:36:49PM +0800, mengdong.lin at linux.intel.com
> wrote:
> 
> > @@ -508,6 +541,10 @@ static void remove_link(struct
> snd_soc_component *comp,
> >  	if (dobj->ops && dobj->ops->link_unload)
> >  		dobj->ops->link_unload(comp, dobj);
> >
> > +	kfree(link->name);
> > +	kfree(link->stream_name);
> > +	kfree(link->cpu_dai_name);
> > +
> >  	list_del(&dobj->list);
> >  	snd_soc_remove_dai_link(comp->card, link);
> >  	kfree(link);
> > @@ -1606,7 +1643,8 @@ static int soc_tplg_dai_create(struct soc_tplg
> *tplg,
> >  	if (dai_drv == NULL)
> >  		return -ENOMEM;
> >
> > -	dai_drv->name = pcm->dai_name;
> > +	if (strlen(pcm->dai_name))
> > +		dai_drv->name = kstrdup(pcm->dai_name, GFP_KERNEL);
> >  	dai_drv->id = pcm->dai_id;
> >
> >  	if (pcm->playback) {
> 
> These appear to be fixes unrelated to the ABI handling?

Sorry, they're not related to ABI handling. I'll move them to other patches.

Thanks
Mengdong