[alsa-devel] [PATCH] ASoC: nau8825: add programmable biquad filter control

Mark Brown broonie at kernel.org
Tue May 31 19:39:00 CEST 2016


On Tue, May 31, 2016 at 11:57:41AM +0800, John Hsu wrote:

> +	if (!component->regmap)
> +		return -EINVAL;

> +	regmap_raw_read(component->regmap, NAU8825_REG_BIQ_COF1,
> +		ucontrol->value.bytes.data, params->max);
> +	return 0;

You should really check the return code from regmap, especially for
larger block transfers where some controllers may have limitations.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160531/56ea8c4b/attachment.sig>


More information about the Alsa-devel mailing list