[alsa-devel] [PATCH 2/2] ASoC: wm8985: add support for WM8758

[Mark Brown]

On Thu, May 12, 2016 at 05:54:37PM +0200, Petr Kulhavy wrote:

> +static const struct snd_kcontrol_new wm8758_snd_controls[] = {
> +	SOC_SINGLE("Digital Loopback Switch", WM8985_COMPANDING_CONTROL,
> +		0, 1, 0),

>  static const struct snd_kcontrol_new wm8985_snd_controls[] = {
>  	SOC_SINGLE("Digital Loopback Switch", WM8985_COMPANDING_CONTROL,
>  		0, 1, 0),

Rather than completely duplicating the set of controls it is better to
have one table with all the shared controls and then extra tables for
those that are device specific that are registered in probe, that way
we only define things once.  The wm8904 driver provides an example of
doing this sort of thing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160513/30d69b96/attachment.sig>