[alsa-devel] [PATCH] ASoC: fsl_sai: Allow the SAI driver to turn on SAI_MCLK

[Fabio Estevam]

On Tue, May 3, 2016 at 10:44 PM, Nicolin Chen <nicoleotsuka at gmail.com> wrote:

> The field names are literally saying "direction" instead of gating
> or enabling. So it would make more sense to me that they may also

Looking in the MX6UL Referece Manual we have the following description
for these bits:

0 - "...output driver is disabled..."

1 - "...output driver is enabled..."

That's why I preferred using 'enabled' in the property name.

I removed Zidan's email from Cc as his email address is no longer valid.

>> +     if (of_find_property(np, "fsl,sai-enable-mclk", NULL)) {
>
> It would safer to have a compatible check here beside mentioning in
> the DT binding doc.

In this case I need to add a { .compatible = "fsl,imx6ul-sai", }, entry.

I can do that.

> How about:
>                 regmap_update_bits(gpr, IOMUXC_GPR1,
>                                    IMX6UL_GPR1_SAIx_MCLK_DIR(index),
>                                    IMX6UL_GPR1_SAIx_MCLK_DIR(index));

That's a good idea.

Will send a v2 tomorrow.

Thanks