[alsa-devel] [PATCH v2 1/2] ASoC: qcom: Fix uninitialized symbol warning.
Srinivas Kandagatla
srinivas.kandagatla at linaro.org
Thu Mar 31 20:23:14 CEST 2016
This patch fixes following static checker warning, by initializing the
ret to -EINVAL, as one of the code path in lpass_platform_pcm_new()
uses this variable uninitialized.
sound/soc/qcom/lpass-platform.c:555 lpass_platform_pcm_new()
error: uninitialized symbol 'ret'.
Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>
---
Changes since v1:
- Split the patch into two as suggested by Mark.
sound/soc/qcom/lpass-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c
index 6e86654..f5cae01 100644
--- a/sound/soc/qcom/lpass-platform.c
+++ b/sound/soc/qcom/lpass-platform.c
@@ -474,7 +474,7 @@ static int lpass_platform_pcm_new(struct snd_soc_pcm_runtime *soc_runtime)
struct lpass_data *drvdata =
snd_soc_platform_get_drvdata(soc_runtime->platform);
struct lpass_variant *v = drvdata->variant;
- int ret;
+ int ret = -EINVAL;
struct lpass_pcm_data *data;
size_t size = lpass_platform_pcm_hardware.buffer_bytes_max;
--
2.5.0
More information about the Alsa-devel
mailing list