[alsa-devel] [PATCH v2] ASoC: rt5514: add rt5514 SPI driver

[Mark Brown]

On Thu, Mar 31, 2016 at 06:29:51AM +0000, Oder Chiou wrote:
> > > +static void rt5514_enable_dsp_prepare(struct rt5514_priv *rt5514)
> > > +{
> > > +	/* Reset */
> > > +	regmap_write(rt5514->i2c_regmap, 0x18002000, 0x000010ec);

> > This is a *very* big table of magic numbers with what look like system
> > specific settings in there (there seem to be some things routing to and
> > from the ADC, and some clocking setup...).  Are you sure none of this
> > depends on the runtime configuration?

> Yes, it is independent of the ASoC runtime configuration. The table of
> magic numbers is the settings for the voice wake up, so it is not required
> to be run on ASoC framework.

Are you *positive* about that?  There look to be routing things going on
for example which might be system dependant.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160331/6809a831/attachment.sig>