[alsa-devel] [PATCH v2 1/5] Sound: SOC: TAS571x: added missing register literals

[Mark Brown]

On Tue, Mar 29, 2016 at 09:39:34AM +0200, Petr Kulhavy wrote:

> The list of TAS571x registers was incomplete.
> Added the missing register definitions up to register 0x25

According to the driver the device has registers up to 0xff?

>  /* device registers */
> +#define TAS571X_CLK_CTRL_REG		0x00
> +#define TAS571X_DEV_ID_REG		0x01
> +#define TAS571X_ERR_STATUS_REG		0x02
> +#define TAS571X_SYS_CTRL_1_REG		0x03

These look like volatile registers but the device has a register cache
and we're not adding a list of volatile registers (or readable registers
for that matter).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160329/f150c2f3/attachment.sig>