[alsa-devel] [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy

Vinod Koul vinod.koul at linux.intel.com
Fri Mar 18 06:17:12 CET 2016


On Thursday 17 March 2016 09:12 PM, Mark Brown wrote:
> On Thu, Mar 17, 2016 at 01:37:16PM +0100, Lars-Peter Clausen wrote:
>
>> I'd say as a quick fix for stable check that card is not NULL in
>> dapm_widget_show_component(). And as a longterm fix get rid of dapm_widget
>> file. Nobody should hopefully use it anymore with debugfs being available as
>> the far better alternative.
>
> Getting rid of the file is definitely not a bad idea but I'd still like
> to see us make the dummy component more consistent with other components
> in order to minimise the chances that we'll run into other special
> cases.

Right, I do see that we need dummy component to be fixed up. Today if we 
use dummy twice in a card it refers to same instance whereas IMO it 
should create separate instances. I will try something on these lines in 
next month or so...

-- 
~Vinod


More information about the Alsa-devel mailing list