[alsa-devel] [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy

Mark Brown broonie at kernel.org
Thu Mar 17 10:54:38 CET 2016


On Wed, Mar 16, 2016 at 07:17:51PM +0800, Harry Pan wrote:

> Conflicts:
> 	sound/soc/soc-dapm.c

Don't include noise like this in upstream submissions.

> +	if (!strcmp(cmpnt->name, "snd-soc-dummy"))
> +		return 0;
> +

This doesn't make much sense and is going to be very fragile.  We
should either make the dummy component look like other components or
make the code cope with them as they stand, that way we don't have
random undocumented special cases scattered through the code.  Probably
it's better to make the dummy component look like others.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160317/5d34cb97/attachment.sig>


More information about the Alsa-devel mailing list